Skip to content

Multi-dimensional batch calculation: list of update batch dataset as a cartesian product #1201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
TonyXiang8787 merged 80 commits into from
Jan 7, 2026
Merged

Multi-dimensional batch calculation: list of update batch dataset as a cartesian product #1201

TonyXiang8787 merged 80 commits into from
Jan 7, 2026

Conversation

@TonyXiang8787
Copy link
Member

@TonyXiang8787 TonyXiang8787 commented Nov 25, 2025 •
edited by figueroa1395
Loading

Closes #1176

Let user to provide a list of update batch datasets, which are used as cartesian product to produce a multi-dimentional batch calculation.

The implementation is a cartesian product over a linked list.

check list

  • C-API and core
  • C-API test
  • C-API in-code documentation
  • Python wrapper
  • Python test
  • Python in-code documentation
  • Adjustment on general documentation and examples

@TonyXiang8787
start slice dataset
8085e5b 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
add slice scenario
73d85c5 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
Merge branch 'main' into experimental/multi-dimension-batch
234f38d
@TonyXiang8787
batch dimension
be44d80 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
calculation implementation
1fd7ed3 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
error handling still needs to be done
45f4d72 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
error handling
06cb330 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
add batch dimensions
a4fc01e 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
batch dimension
118655f 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
start test
3b41f28 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
start test
d88db97 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
api will not work as intended
1b1190d 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
api will not work as intended
21c31c5 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
adjust md dataset
6e8c081 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
add dataset
0b989b4 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
crash yet
14b4039 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix bounds checking
3338881 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
remove span
01c86a9 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix clang tidy
7786b0c 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
format|
5a3f394 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
[skip ci] add cfunc in python
2650968 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
force nullptr
9aaa6bd 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
add options
e4aa439 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
proxy for multidimensional in python
237681f 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
modify main calculate input
b602f2e 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
type annotation
3e79237 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
[skip ci] not working yet
8d8d80c 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix dimensions
61cfd57 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
fix mypy
a1331ba 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
Merge branch 'main' into experimental/multi-dimension-batch
36707d9
@figueroa1395
Copy link
Member

figueroa1395 commented Dec 15, 2025

@mgovers @figueroa1395 @nitbharambe,
The main part is almost finished. We still need to add general documentation and some notebook examples. I propose one of you to add this. This make sure we actually have the same understanding about how cartesian product of MD batch calculation works.

Good idea. I can probably pick this up. I'll bring it to Peter today so we allocate some time for it.

Edit: No further comments from me. It looks good to me at this stage besides the additional stuff you pointed out. I would only also silence the Sonar Cloud warnings as I deem them false positives.

@TonyXiang8787 I can pick this up whenever you give me the green light and finish it off.

@TonyXiang8787
Copy link
Member Author

TonyXiang8787 commented Dec 16, 2025

@mgovers @figueroa1395 @nitbharambe,
The main part is almost finished. We still need to add general documentation and some notebook examples. I propose one of you to add this. This make sure we actually have the same understanding about how cartesian product of MD batch calculation works.

Good idea. I can probably pick this up. I'll bring it to Peter today so we allocate some time for it.
Edit: No further comments from me. It looks good to me at this stage besides the additional stuff you pointed out. I would only also silence the Sonar Cloud warnings as I deem them false positives.

@TonyXiang8787 I can pick this up whenever you give me the green light and finish it off.

@figueroa1395 it's ready now. So go ahead.

TonyXiang8787 and others added 4 commits December 19, 2025 11:17
@TonyXiang8787
Merge branch 'main' into experimental/md-batch-chaining
6728662
@figueroa1395
Merge branch 'main' into experimental/md-batch-chaining
fb9486c
@nitbharambe
add documentation
f5ae291 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
change print
b1626bd 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe nitbharambe mentioned this pull request Dec 31, 2025
Merged
nitbharambe and others added 2 commits January 2, 2026 13:55
@nitbharambe
rename to cartesian product
974437a 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
Apply suggestion from @nitbharambe
ce0a529 
Signed-off-by: Nitish Bharambe <78108900+nitbharambe@users.noreply.github.com>
@mgovers mgovers mentioned this pull request Jan 5, 2026
Open
20 tasks
figueroa1395 and others added 7 commits January 5, 2026 17:41
@figueroa1395
Merge branch 'main' into experimental/md-batch-chaining
247d855
@nitbharambe
resolve comments
195ba5f 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@nitbharambe
resolve comments 2
57d5149 
Signed-off-by: Nitish Bharambe <nitish.bharambe@alliander.com>
@TonyXiang8787
Merge branch 'main' into experimental/md-batch-chaining
79be1f8
@TonyXiang8787
fix threading issue
5840870 
Signed-off-by: Tony Xiang <19280867+TonyXiang8787@users.noreply.github.com>
@TonyXiang8787
Merge branch 'experimental/md-batch-chaining' into docs/batch-chaining
13141a3
@TonyXiang8787
Merge pull request #1246 from PowerGridModel/docs/batch-chaining
1035a80 
Multi-dimensional batch calculation: documentation
@TonyXiang8787 TonyXiang8787 removed the do-not-merge This should not be merged label Jan 6, 2026
@TonyXiang8787
Copy link
Member Author

TonyXiang8787 commented Jan 6, 2026

@figueroa1395 @nitbharambe @mgovers, the examples and documentations are merged here. Feel free to give green light to merge.

@TonyXiang8787 TonyXiang8787 marked this pull request as ready for review January 6, 2026 13:17
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 7, 2026

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
83.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

figueroa1395
figueroa1395 approved these changes Jan 7, 2026
View reviewed changes
Copy link
Member

@figueroa1395 figueroa1395 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing new to add, looks good to me. Approving.

I see readthedocks failing, but I expect it to be fixed with a re-run, so I'll do so.

@TonyXiang8787 TonyXiang8787 added this pull request to the merge queue Jan 7, 2026
Merged via the queue into main with commit da83e82 Jan 7, 2026
53 of 56 checks passed
@TonyXiang8787 TonyXiang8787 deleted the experimental/md-batch-chaining branch January 7, 2026 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mgovers mgovers mgovers approved these changes

@figueroa1395 figueroa1395 figueroa1395 approved these changes

Assignees

@TonyXiang8787 TonyXiang8787

Labels

feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE] 2-D or cross-join of batch updates

5 participants

@TonyXiang8787 @figueroa1395 @mgovers @nitbharambe